-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: update browser icons #30790
Merged
Merged
misc: update browser icons #30790
+263
−327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacieprins
requested changes
Dec 19, 2024
cypress Run #59469
Run Properties:
|
Project |
cypress
|
Branch Review |
mschile/browser_icon_updates
|
Run status |
Passed #59469
|
Run duration | 11m 22s |
Commit |
af8e1e3c78: use invisible class
|
Committer | Matthew Schile |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
1
|
Skipped |
0
|
Passing |
669
|
View all changes introduced in this branch ↗︎ |
UI Coverage
38.03%
|
|
---|---|
Untested elements |
132
|
Tested elements |
81
|
Accessibility
92.03%
|
|
---|---|
Failed rules |
3 critical
7 serious
1 moderate
1 minor
|
Failed elements |
543
|
cacieprins
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Steps to test
Verify the icons are correct.
How has the user experience changed?
Browser selection:
Open mode header and dropdown:
Debug:
Run mode header:
Automation missing:
PR Tasks
cypress-documentation
?type definitions
?