Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: update browser icons #30790

Merged
merged 11 commits into from
Jan 7, 2025
Merged

misc: update browser icons #30790

merged 11 commits into from
Jan 7, 2025

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 19, 2024

  • Closes n/a

Additional details

  • Updated to use the @cypress-design system browser icons

Steps to test

Verify the icons are correct.

How has the user experience changed?

Browser selection:
Screenshot 2024-12-19 at 9 19 02 AM

Open mode header and dropdown:
Screenshot 2024-12-19 at 9 19 38 AM

Debug:
Screenshot 2024-12-19 at 9 20 33 AM

Run mode header:
Screenshot 2024-12-19 at 9 22 39 AM

Automation missing:
Screenshot 2024-12-20 at 8 33 04 AM

PR Tasks

@mschile mschile self-assigned this Dec 19, 2024
Copy link

cypress bot commented Dec 19, 2024

cypress    Run #59469

Run Properties:  status check passed Passed #59469  •  git commit af8e1e3c78: use invisible class
Project cypress
Branch Review mschile/browser_icon_updates
Run status status check passed Passed #59469
Run duration 11m 22s
Commit git commit af8e1e3c78: use invisible class
Committer Matthew Schile
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 669
View all changes introduced in this branch ↗︎
UI Coverage  38.03%
  Untested elements 132  
  Tested elements 81  
Accessibility  92.03%
  Failed rules  3 critical   7 serious   1 moderate   1 minor
  Failed elements 543  

@mschile mschile merged commit 558906f into develop Jan 7, 2025
84 of 85 checks passed
@mschile mschile deleted the mschile/browser_icon_updates branch January 7, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants